Skip to content
This repository has been archived by the owner on Apr 12, 2022. It is now read-only.

Spechelper Test Server Error Handling Improvements #2977

Merged
merged 3 commits into from Feb 17, 2022

Conversation

teallarson
Copy link
Contributor

@teallarson teallarson commented Feb 16, 2022

Change description

Found when pairing with @evantahler: When starting a server in detached mode (how front end tests are run), server errors did not previously surface.

Now, these errors are surfaced and will show up in the jest error reporting when the server cannot start.

Checklists

Development

  • Application changes have been tested appropriately

Impact

  • Code follows company security practices and guidelines
  • Security impact of change has been considered
  • Performance impact of change has been considered
  • Possible migration needs considered (model migrations, config migrations, etc.)

Please explain any security, performance, migration, or other impacts if relevant:

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached where applicable.
  • Relevant tags have been added to the PR (bug, enhancement, internal, etc.)

@teallarson teallarson added the enhancement New feature or request label Feb 16, 2022
Copy link
Member

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, except for my old mistakes in that method...

plugins/@grouparoo/spec-helper/src/lib/specHelper.ts Outdated Show resolved Hide resolved
plugins/@grouparoo/spec-helper/src/lib/specHelper.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@edmundito edmundito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@teallarson teallarson merged commit 4a50501 into main Feb 17, 2022
@teallarson teallarson deleted the spechelper-testserver-error-handling branch February 17, 2022 17:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants