This repository has been archived by the owner on Apr 12, 2022. It is now read-only.
Put email regex back to old, fixed tests #3004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedroslopez
reviewed
Feb 24, 2022
Comment on lines
5
to
7
| * We cannot use import isEmail from "validator/lib/isEmail" until https://github.com/validatorjs/validator.js/pull/1435 is merged in. | ||
| */ | ||
| export default function isEmail(string: string) { |
There was a problem hiding this comment.
This comment is waiting on something to be merged that has been merged at this point. We have validator installed... could we just use that?
If not, maybe this comment should be removed
There was a problem hiding this comment.
That'd be an @bleonard call.
There was a problem hiding this comment.
I'd remove that comment - we still don't really want to use the more strict email validator from validator.js - they won't like the leading/trailing spaces
evantahler
approved these changes
Feb 24, 2022
Comment on lines
5
to
7
| * We cannot use import isEmail from "validator/lib/isEmail" until https://github.com/validatorjs/validator.js/pull/1435 is merged in. | ||
| */ | ||
| export default function isEmail(string: string) { |
There was a problem hiding this comment.
I'd remove that comment - we still don't really want to use the more strict email validator from validator.js - they won't like the leading/trailing spaces
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Put email regex back to old, fixed tests
Checklists
Development
Impact
Please explain any security, performance, migration, or other impacts if relevant:
Code review