fix(hubspot): don't modify the options object when getting destination options #3011

pedroslopez · 2022-02-28T18:01:31Z

Change description

This was causing validation to fail because of unexpected nulls, meaning that hubspot destinations could not be created.

Because these were in here to clear out invalid values, this should no longer be necessary since core's validation introduced in #2988 will prevent these from being set in the first place.

Also fixed up the filterEmptyOptions method to also clear nulls and undefineds

Checklists

Development

Application changes have been tested appropriately

Impact

Code follows company security practices and guidelines
Security impact of change has been considered
Performance impact of change has been considered
Possible migration needs considered (model migrations, config migrations, etc.)

Please explain any security, performance, migration, or other impacts if relevant:

Code review

Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached where applicable.
Relevant tags have been added to the PR (bug, enhancement, internal, etc.)

evantahler · 2022-02-28T18:46:59Z

core/src/modules/optionHelper.ts

    Object.keys(opts).forEach((k) => {
-      if (opts[k] === "") delete opts[k];
+      if (typeof opts[k] === "undefined" || opts[k] === null || opts[k] === "")
+        delete opts[k];


don't modify the options object when getting destination options

54c5c9e

pedroslopez added the bug Something isn't working label Feb 28, 2022

filter nulls/undefineds

c78ade0

pedroslopez requested review from pauloouriques and evantahler February 28, 2022 18:35

evantahler approved these changes Feb 28, 2022

View reviewed changes

pedroslopez merged commit 5d51266 into main Feb 28, 2022

pedroslopez deleted the fix-hubspot-options branch February 28, 2022 19:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(hubspot): don't modify the options object when getting destination options #3011

fix(hubspot): don't modify the options object when getting destination options #3011

pedroslopez commented Feb 28, 2022 •

edited

evantahler Feb 28, 2022

fix(hubspot): don't modify the options object when getting destination options #3011

fix(hubspot): don't modify the options object when getting destination options #3011

Conversation

pedroslopez commented Feb 28, 2022 • edited

Change description

Checklists

Development

Impact

Code review

evantahler Feb 28, 2022

Choose a reason for hiding this comment

pedroslopez commented Feb 28, 2022 •

edited