This repository has been archived by the owner on Apr 12, 2022. It is now read-only.
Source now only uses name for a unique composite key. #3085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishnaglick
added
bug
krishnaglick
commented
Mar 4, 2022
| @@ -141,8 +141,6 @@ export class Source extends CommonModel<Source> { | |||
| @BelongsTo(() => GrouparooModel) | |||
| model: GrouparooModel; | |||
|
|
|||
| uniqueIdentifier = ["appId", "name"]; | |||
There was a problem hiding this comment.
commonModel defaults this to name.
evantahler
approved these changes
Mar 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Source now only uses name for a unique
compositekey. Explicit test added.Checklists
Development
Impact
Please explain any security, performance, migration, or other impacts if relevant:
Code review