Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SFX-437: Rename project to "Elements" #18

Merged
merged 6 commits into from
Nov 4, 2019
Merged

SFX-437: Rename project to "Elements" #18

merged 6 commits into from
Nov 4, 2019

Conversation

ChantalDesrochers
Copy link
Contributor

No description provided.

@ChantalDesrochers ChantalDesrochers requested review from jmbtutor, DanielMoniz-GBI and ssbelle and removed request for jmbtutor October 31, 2019 18:34
Copy link
Collaborator

@jmbtutor jmbtutor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

package.json Outdated
@@ -1,7 +1,7 @@
{
"name": "@sfx/events",
"name": "@elements/events",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our package name is probably going to be @groupby/elements-events, but we can change that later when we actually release.

Copy link
Collaborator

@jmbtutor jmbtutor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapproving for the new change.

@ChantalDesrochers ChantalDesrochers merged commit 5adb9c1 into master Nov 4, 2019
@geoffcoutts geoffcoutts deleted the SFX-437 branch November 25, 2019 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants