Apply latest generator #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markowsiak
force-pushed
the
apply-nlm-generator
branch
from
82c8e98
to
c99bb3f
Compare
dbushong
requested changes
Jan 4, 2018
lib/diff-stub.js
Outdated
| //# sourceMappingURL=diff-stub.js.map |
There was a problem hiding this comment.
this file (and the .map) should just be deleted i think. eslint also shouldn't run on lib/ in this repo, just on src/
There was a problem hiding this comment.
@dbushong I thought the same thing about the diff-stub files. They're now removed. The package.json entries for linting in pretest should already lint just src and test as well. 👍
markowsiak
force-pushed
the
apply-nlm-generator
branch
from
c99bb3f
to
8a01540
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.