no longer depend/break on global _
#43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
browser-side there might be underscorejs present, which doesn't have all of the lodash methods. node-side we don't really need all of lodash all that much anymore. the one sticking point is `_.isEqual()`, which is a bit large to replicate, so we'll go ahead and depend on `lodash.isequal`, which will break some browser use cases BREAKING CHANGE: no longer works without SOME CommonJS compatibility (e.g. node, browserify)
dbushong
force-pushed
the
dbushong/feature/master/nuke-lodash
branch
from
bc32dc9
to
58884fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
browser-side there might be underscorejs present, which doesn't have all
of the lodash methods.
node-side we don't really need all of lodash all that much anymore.
the one sticking point is
_.isEqual(), which is a bit large toreplicate, so we'll go ahead and depend on
lodash.isequal, which willbreak some browser use cases
BREAKING CHANGE: no longer works without SOME CommonJS compatibility (e.g. node, browserify)