Skip to content
This repository has been archived by the owner on Jun 13, 2019. It is now read-only.

Add snyk.io to pipeline? #1

Closed
guypod opened this issue Mar 2, 2016 · 11 comments
Closed

Add snyk.io to pipeline? #1

guypod opened this issue Mar 2, 2016 · 11 comments

Comments

@guypod
Copy link

guypod commented Mar 2, 2016

A bit of a shameless plug, as I work on Snyk, but I believe it fits.
Snyk works off an open source vuln DB (https://github.com/Snyk/vulndb), and includes patches (typically reduced & back-ported versions of the original fix), that make remediation very actionable.

@guypod
Copy link
Author

guypod commented Mar 2, 2016

A couple of sample Snyk results on Groupon projects (though typically you'll run Snyk from the CLI):

https://snyk.io/test/github/groupon/nlm
https://snyk.io/test/github/groupon/report-card
https://snyk.io/test/github/groupon/DotCi

@10dot
Copy link
Contributor

10dot commented Mar 2, 2016

Definitely interested! Two questions:

  • I don't see anything in the docs re: ouput formatting or in the command line help... does Snyk have an easy way to output JSON or XML? It's not a show stopper if not, it'll just make things easier.
  • What differentiates Snyk from retire.js/nodesecurity, the remediation (which is very interesting, fwiw)?

@guypod
Copy link
Author

guypod commented Mar 2, 2016

Great!

Re json, you can specify a --json argument to 'snyk test' to get json output. Good point on it missing from the docs, we'll fix that.

Re difference, the main delta is remediation. That said, the tools operate a bit differently. There are a handful of issues in our DB that aren't in nodesecurity (our DB is at https://github.com/Snyk/vulndb), and we've encountered various packages where we reported issues while they did not.

@10dot
Copy link
Contributor

10dot commented Mar 2, 2016

It's on the list for pipeline now; I'll get it added probably next week and update codeburner as soon as the new gem is published.

Thanks for the submission!

@10dot
Copy link
Contributor

10dot commented Mar 10, 2016

I started working on this integration today, unfortunately I hit a snag.

I ran snyk against about a dozen different javascript apps, some of which have known vulns caught by nodesecurity or retire. I have yet to get snyk to report a single result, unfortunately. I even tried it against the snyk-demo-app I found reference to with no luck.

I'm running npm 3.3.3 and node 0.12.7 if it helps...

@guypod
Copy link
Author

guypod commented Mar 10, 2016

One thought: do you run Snyk.io after running npm install?

When you run snyk locally, it tests the set of packages actually deployed. The npm install logic is pretty complicated, especially when you factor in deduplication and shrinkwrap, so we determined its best to test what is actually deployed. I believe nsp doesn't work that way (making it mis-report or totally miss some issues).

Can you try running it after npm install and see if you're getting the issues as expected?

@10dot
Copy link
Contributor

10dot commented Mar 10, 2016

Aha, got it! That's the same logic as retirejs, so I totally get it/agree... you might want to add that as another notch in the documentation belt, though, since I didn't see it mentioned anywhere :)

I've got some decent data now, and I already added a hook to specify a custom npm-registry in pipeline for our retirejs support (which does an npm install --no-scripts before it runs in pipeline) so this should work fine.

Thanks for the quick reply!

@10dot
Copy link
Contributor

10dot commented Mar 16, 2016

FYI this is done, I'm just waiting to finish 1 more (big) feature for pipeline before I submit the PR/add it to codeburner proper.

FWIW the Markdown details actually look pretty nice in the codeburner interface after an html conversion ;)

@guypod
Copy link
Author

guypod commented Mar 16, 2016

Awesome - will test it out a bit later!

@10dot
Copy link
Contributor

10dot commented Mar 21, 2016

Fixed in pipeline: OWASP/glue#28

Once that's merged I'll update codeburner and Snyk support will be in.

@10dot
Copy link
Contributor

10dot commented Apr 21, 2016

This all finally made it in to today's release, Snyk is fully supported now.

@10dot 10dot closed this as completed Apr 21, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants