Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Coffeescript dependency to 1.12.7 #89

Closed
KingDarBoja opened this issue Nov 23, 2020 · 3 comments
Closed

Pin Coffeescript dependency to 1.12.7 #89

KingDarBoja opened this issue Nov 23, 2020 · 3 comments
Labels

Comments

@KingDarBoja
Copy link

Hello cson-parser maintainers,

The current library is being used at tslint-to-eslint-config package to support Atom config files parsing in order to convert some options from TSLint to ESLint ones. However, we found that the current coffeescript dependency uses the minor semversion range (^) starting from 1.12.7, which attempts to install the non-existent 1.12.8 version.

A ticket explaining such behaviour was opened on the repository with the reproduction steps:
typescript-eslint/tslint-to-eslint-config#839

The correct behaviour should be to pin the dependency to 1.12.7 only to avoid such scenario.

Cheers!

aaarichter pushed a commit that referenced this issue Nov 23, 2020
@aaarichter
Copy link

Hey @KingDarBoja ,

thanks for raising this issue. I just opened a PR to freeze coffeescript to the given version.

@aaarichter aaarichter added the bug label Nov 23, 2020
@aaarichter
Copy link

the PR is merged and v4.0.7 is released. closing

@KingDarBoja
Copy link
Author

That was fast! Thank you 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants