Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply latest nlm generator #6

Merged
merged 1 commit into from
Jan 5, 2018
Merged

Apply latest nlm generator #6

merged 1 commit into from
Jan 5, 2018

Conversation

markowsiak
Copy link
Contributor

This PR was created by a machine.

nlm is a tool for automating the release of node packages. There are some notable implications of using nlm:

  • Commits messages are used to determine the semver implications of the changes.
  • The above means that all commits have to follow the angular commit message conventions so nlm can parse them.
  • Releases happen automatically from CI after successful builds of the master branch. There's no manual intervention required.

Additionally some standard dependency versions were enforced:

  • bluebird@^3.3.3
  • lodash@^4.6.1

/cc @groupon/itier

@jkrems
Copy link
Contributor

jkrems commented Jan 4, 2018

I think this is missing additional .gitignore entries for the nested package-lock.json files. Otherwise LGTM!

@markowsiak markowsiak force-pushed the apply-nlm-generator branch 2 times, most recently from f01872a to 68951f5 Compare January 4, 2018 22:26
@markowsiak markowsiak merged commit 7e16511 into master Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants