Merge pull request #108 from groupon/dbushong/feature/master/optional…

…-path-params optional path params
groupon · Oct 24, 2019 · 8391ee7 · 8391ee7
2 parents b4caf80 + de401c7
commit 8391ee7
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/lib/typedefs.d.ts b/lib/typedefs.d.ts
@@ -42,10 +42,13 @@ declare class Gofer {
 }
 
 declare namespace Gofer {
-  export function fetch(path: string, opts?: Gofer.FetchOpts): FetchResponse;
+  export function fetch(
+    path: string,
+    opts?: Gofer.FetchOpts & { pathParams?: { [param: string]: string } }
+  ): FetchResponse;
 
   export type Opts = {
-    pathParams?: { [param: string]: string };
+    pathParams?: { [param: string]: string | undefined };
     timeout?: number;
     connectTimeout?: number;
     searchDomain?: string;

diff --git a/package-lock.json b/package-lock.json