fix: merge URLSearchParams qs arguments #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use modern classes * use assert instead of assertive
and add test for qs merging
```js
const client = new Gofer({ c: { qs: { id: 'x' } } }, 'c');
// both of these now work and request /go?id=x&other=y
await client.get('/go', { qs: { other: 'y' } });
// fixed
await client.get('/go', { qs: new URLSearchParams({ other: 'y' }) });
```
dbushong
commented
May 22, 2022
Comment on lines
-93
to
+97
| function preventComplexMerge(objValue, srcValue) { | ||
| function goferMerge(objValue, srcValue) { |
There was a problem hiding this comment.
Just renamed to reflect broader functionality
values for a given key replace all values for existing key
(don't think this rises to the level of breaking):
```js
const config = { c: { qs: { a: '1', b: '3' } } };
const client = new Gofer(config, 'c');
console.log(client.getMergedOptions(
{},
{ qs: new URLSearchParams([['a', '2'], ['a', '4']]) }
));
// before:
// new URLSearchParams([['a', '1'], ['b', '3'], ['a', '2'], ['a', '4']])
// now: (note existing a: 1 has been removed)
// new URLSearchParams([['a', '2'], ['b', '3'], ['a', '4']])
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: values for a given key replace all values for existing key
(don't think this rises to the level of breaking):
This PR was started by: git wf pr