Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish 3.x from master #76

Merged
merged 1 commit into from
Jun 21, 2017
Merged

Publish 3.x from master #76

merged 1 commit into from
Jun 21, 2017

Conversation

jkrems
Copy link
Collaborator

@jkrems jkrems commented Jun 21, 2017

No description provided.

Copy link
Member

@dbushong dbushong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q & 🐑

"channels": {
"3.x": "beta",
"master": "latest"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to have the channels section be the same (knowing about 2.x) on both?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could have the same channels section here but since we're not actually merging between the two, there's little advantage. Both would be valid.

@jkrems jkrems merged commit d99b1f8 into master Jun 21, 2017
@jkrems jkrems deleted the jk-3.x-latest branch June 21, 2017 17:25
@jkrems
Copy link
Collaborator Author

jkrems commented Jun 21, 2017

Let me know if I didn't convince you. Happy to add a channels config on master for consistency. :)

@dbushong
Copy link
Member

Nah, it's fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants