Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply latest nlm generator #79

Merged
merged 1 commit into from
Jan 3, 2018

Conversation

markowsiak
Copy link
Contributor

This PR was created by a machine.

nlm is a tool for automating the release of node packages. There are some notable implications of using nlm:

Commits messages are used to determine the semver implications of the changes.
The above means that all commits have to follow the angular commit message conventions so nlm can parse them.
Releases happen automatically from CI after successful builds of the master branch. There's no manual intervention required.
Additionally some standard dependency versions were enforced:

bluebird@^3.3.3
lodash@^4.6.1

Copy link
Collaborator

@jkrems jkrems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubberstamp-ish LGTM. Restarted the failed node 6 job since it seemed like a timing issue. Eventually we might want to look into that but not a blocker for this change.

.travis.yml Outdated
- npm install -g npm@latest-2
before_deploy:
- git config user.email "opensource@groupon.com"
- git config user.name "Groupon"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't need these 5 lines anymore

@markowsiak markowsiak merged commit 7ff7f8f into groupon:master Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants