don't set connect timeout for keepalive #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkrems
requested changes
Jun 7, 2018
lib/request.js
Outdated
| connectTimer = setIOTimeout(onConnectTimedOut, options.connectTimeout); | ||
| socket.once('connect', onConnect); | ||
| if (socket._connecting || socket.connecting) { | ||
| timing.socket = Date.now() - startTime; |
There was a problem hiding this comment.
I think we'd still want to record the time it took to get a socket, e.g. in the case of queueing requests.
If you have an existing socket from a KeepAlive connection, the `connect` event will never be fired, which causes the timeout to fire, which was closing the KeepAlive'd connection
dbushong
force-pushed
the
dbushong/feature/master/fix-connect-timeout
branch
from
4b54555
to
cd57ced
Compare
|
fixed |
jkrems
approved these changes
Jun 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have an existing socket from a KeepAlive connection, the
connectevent will never be fired, which causes the timeout to fire,which was closing the KeepAlive'd connection
See: https://github.com/request/request/blob/a6741d415aba31cd01e9c4544c96f84ea6ed11e3/request.js#L778-L779