Take TP config for travis #3
Conversation
You need to configure your ~/.gradle/gradle.properties file and add SONATYPE_NEXUS_USERNAME=<your username on sonatype> SONATYPE_NEXUS_PASSWORD=<your password>
.travis.yml
Outdated
| - $HOME/.m2 | ||
|
|
||
| script: | ||
| - ./gradlew clean build check test |
There was a problem hiding this comment.
check and test are already part of build --> ./gradlew clean build
There was a problem hiding this comment.
right. I will remove them
| #sonatype username and password | ||
| env: | ||
| global: | ||
| - secure: "kKtE5tdRk0mHuEQfBo+nbl32l/coGJokFRNA8CsETlfasAwoAqAZjEuME61t1o8NIhkXieDs+dcYIl28GPxbcgdpF+Ja+ztMAZpgs3bEeGrQBx1appKHaUe2rOcJY79fHuNxeDrwMyl7b2Jcx1c9TBXG2SI95zsSQiHsWJixEqiJ5V8y/T0SmlSxwDc14Alt4cdFT+CtgkdJSZmKdubb65E8Z0s62N3TUcrAOR1e6tMccpEdXdMqZ19bnSp1m5FRx5dUuW0NmhIwSK6e32yy5Ei6MCtvIfBK+X3nSZx3sJ/wuZ36IDw6DJ6oGRj2eTJecswd9Oxlz22LERyl29nyzqQ73ch6h4f9pHW6LnJ0PICb1vn2FrR8SYNK6reoU/DnhI/Aixqqesu1k0TnxGcnmHnPTDOeOlkE2gwDb+2PbKK71b5GVBGb/SxXeu5Y5s1hO2y+3Z0OOVaDwrUgHFgZyUQxE1QiFhhBRBpjr5cxcNIvUc4yMBrPHZkTbNObMfLQgkkn8z89gFOMgkrWzMZSFEWN+8YhZjHVhe6PMBNOdBC2e7GojJdtCKcr5QSKeKf1laR2kTQpHpNmwAH6D/7+kpYpyMVKMER1h+sVHphr/lLB+/e/okCxti1Ngbjb7ml66Du4tzUzJILCaWELdvWCYDZpiZOTJnmoNswQYi/dUXU=" |
There was a problem hiding this comment.
Shouldn't this be hidden?
There was a problem hiding this comment.
This is the mechanism to hide a value. It is encrypted here.
| * limitations under the License. | ||
| */ | ||
|
|
||
| apply plugin: 'maven' |
There was a problem hiding this comment.
This is the old maven Gradle plugin. We should adopt the new one in the future:
https://docs.gradle.org/3.3/userguide/publishing_maven.html
In addition, I think we should explore the option of including some of the Netflix's Nebula plugins:
https://github.com/nebula-plugins
There was a problem hiding this comment.
I was trying to read about the advantage of using it. I see many OSS projects using it. Do you mind if we create a ticket after the first release is done to try them out ? I don't wanna mix too many things, already the release process has its own problems to deal with which might not be so easy for a first release.
There was a problem hiding this comment.
Yes, I think this should be done separately 👍
| sign configurations.archives | ||
| } | ||
|
|
||
| if (project.getPlugins().hasPlugin('com.android.application') || |
There was a problem hiding this comment.
I need to OSS my android-maven-publish Gradle plugin :P
| @@ -2,6 +2,7 @@ apply plugin: 'java' | |||
| apply plugin: 'me.tatarka.retrolambda' | |||
| apply from: rootProject.file("${quality_gradle_java_file}") | |||
| apply plugin: 'com.github.hierynomus.license' | |||
| apply from: rootProject.file('gradle/gradle-mvn-push.gradle') | |||
There was a problem hiding this comment.
Can this be applied from the parent build.gradle?
There was a problem hiding this comment.
we don't want to publish the samples, so I added it on a per module basis.
There was a problem hiding this comment.
I think this should work:
configure(allprojects - project(':grox-sample') - project(':grox-sample-rx')) {
apply from: rootProject.file('gradle/gradle-mvn-push.gradle')
}There was a problem hiding this comment.
Another option is:
allprojects {
if (!it.name.startsWith('grox-sample')) {
apply from: rootProject.file('gradle/gradle-mvn-push.gradle')
}
}There was a problem hiding this comment.
Sure we can do something like this, but isn't it better to have it inside the project then, as it is ? Relying on module names is a bit fragile IMHO.
|
|
Solves #1
@ reviewers, feel free to squash and merge.