Skip to content

Commit

Permalink
refactor: Drop dependency on lerna & airbnb
Browse files Browse the repository at this point in the history
BREAKING CHANGE: This switches our linting to an entirely new
set of rules. For the most part we're trying to stay consistent
with the old format to reduce churn but it explicitly is a departure.
  • Loading branch information
Jan Krems committed Aug 25, 2017
1 parent 7f5fb83 commit 559c99f
Show file tree
Hide file tree
Showing 71 changed files with 157 additions and 1,065 deletions.
File renamed without changes.
20 changes: 20 additions & 0 deletions es5.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
'use strict';

module.exports = {
parserOptions: {
sourceType: 'script',
ecmaVersion: 5,
},
rules: {
'no-param-reassign': 0,
'prefer-rest-params': 0,
'no-underscore-dangle': [2, { allowAfterThis: true }],
strict: [2, 'global'],
'comma-dangle': [2, {
arrays: 'always-multiline',
objects: 'always-multiline',
functions: 'never',
}],
'prefer-spread': 0,
}
};
File renamed without changes.
File renamed without changes.
3 changes: 3 additions & 0 deletions examples/eslint/es5/.eslintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
'use strict';

module.exports = require('../../../es5');
3 changes: 3 additions & 0 deletions examples/eslint/es5/no-arrow.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
'use strict';

(() => {})();
3 changes: 3 additions & 0 deletions examples/eslint/es5/no-arrow.js.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"errorCount": 1
}
File renamed without changes.
File renamed without changes.
3 changes: 3 additions & 0 deletions examples/eslint/node4/.eslintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
'use strict';

module.exports = require('../../../node4');
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
3 changes: 3 additions & 0 deletions examples/eslint/node6/.eslintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
'use strict';

module.exports = require('../../../node6');
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
2 changes: 2 additions & 0 deletions examples/stylint/import-css.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
/* .css files can be included - but we don't support inline css blocks. */
@import('./raw.css');
4 changes: 0 additions & 4 deletions lerna.json

This file was deleted.

24 changes: 24 additions & 0 deletions node4.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
'use strict';

module.exports = {
parserOptions: {
ecmaVersion: 2017,
sourceType: 'script',
},
plugins: [
'node',
],
rules: {
'node/no-unsupported-features': [2, { version: 4 }],
'no-param-reassign': 0,
'prefer-rest-params': 0,
'no-underscore-dangle': [2, { allowAfterThis: true }],
strict: [2, 'global'],
'comma-dangle': [2, {
arrays: 'always-multiline',
objects: 'always-multiline',
functions: 'never',
}],
'prefer-spread': 0,
}
};
21 changes: 21 additions & 0 deletions node6.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
'use strict';

module.exports = {
parserOptions: {
ecmaVersion: 2017,
sourceType: 'script',
},
plugins: [
'node',
],
rules: {
'node/no-unsupported-features': [2, { version: 6 }],
'no-underscore-dangle': [2, { allowAfterThis: true }],
strict: [2, 'global'],
'comma-dangle': [2, {
arrays: 'always-multiline',
objects: 'always-multiline',
functions: 'never',
}],
}
};
25 changes: 8 additions & 17 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
{
"name": "groupon-styleguide",
"version": "3.2.0",
"private": true,
"name": "eslint-config-groupon",
"version": "4.1.4",
"scripts": {
"test": "eslint test/valid/eslint && coffeelint -q test/valid/coffeelint && stylint test/valid/stylint"
"test": "mocha"
},
"license": "BSD-3-Clause",
"repository": {
Expand All @@ -15,27 +14,19 @@
"email": "jan.krems@groupon.com"
},
"dependencies": {
"coffeelint-config-groupon": "file:./packages/coffeelint-config-groupon",
"coffeelint-forbidden-keywords": "~0.1.1",
"coffeelint-no-mocha-only": "^1.0.0",
"coffeelint-use-strict": "^1.0.0",
"coffeescope2": "~0.4.2",
"eslint-config-groupon": "file:./packages/eslint-config-groupon",
"eslint-config-groupon-es5": "file:./packages/eslint-config-groupon-es5",
"eslint-config-groupon-node4": "file:./packages/eslint-config-groupon-node4",
"eslint-config-groupon-node6": "file:./packages/eslint-config-groupon-node6",
"eslint-config-groupon-react": "file:./packages/eslint-config-groupon-react",
"eslint-plugin-jsx-a11y": "^2.2.3",
"eslint-plugin-import": "^2.2.0",
"eslint-plugin-node": "^2.0.0",
"eslint-plugin-react": "^6.6.0",
"stylint-config-groupon": "file:./packages/stylint-config-groupon"
"eslint-plugin-node": "^2.0.0"
},
"devDependencies": {
"coffee-script": "^1.10.0",
"coffeelint": "^1.15.7",
"eslint": "^3.12.2",
"stylint": "^1.5.7",
"lerna": "2.0.0-beta.30"
"eslint": "^4.4.1",
"globby": "^6.1.0",
"mocha": "^3.5.0",
"stylint": "^1.5.7"
}
}
29 changes: 0 additions & 29 deletions packages/coffeelint-config-groupon/LICENSE

This file was deleted.

3 changes: 0 additions & 3 deletions packages/coffeelint-config-groupon/README.md

This file was deleted.

38 changes: 0 additions & 38 deletions packages/coffeelint-config-groupon/package.json

This file was deleted.

29 changes: 0 additions & 29 deletions packages/eslint-config-groupon-es5/LICENSE

This file was deleted.

7 changes: 0 additions & 7 deletions packages/eslint-config-groupon-es5/README.md

This file was deleted.

41 changes: 0 additions & 41 deletions packages/eslint-config-groupon-es5/index.js

This file was deleted.

36 changes: 0 additions & 36 deletions packages/eslint-config-groupon-es5/package.json

This file was deleted.

3 changes: 0 additions & 3 deletions packages/eslint-config-groupon-es5/test/base/.eslintrc

This file was deleted.

This file was deleted.

3 changes: 0 additions & 3 deletions packages/eslint-config-groupon-es5/test/legacy/.eslintrc

This file was deleted.

19 changes: 0 additions & 19 deletions packages/eslint-config-groupon-es5/test/lint.sh

This file was deleted.

29 changes: 0 additions & 29 deletions packages/eslint-config-groupon-node4/LICENSE

This file was deleted.

0 comments on commit 559c99f

Please sign in to comment.