Skip to content

Commit

Permalink
feat: upgrade to prettier2
Browse files Browse the repository at this point in the history
* requires prettier 2.x peer dep
* marked breaking because of number of style changes
* chained methods now often on one line
* arrowParens has old defaults of 'avoid' - we like the old setting
    better for now

See: https://prettier.io/blog/2020/03/21/2.0.0.html

BREAKING CHANGE: requires prettier 2.x peerDep and will result in a
lot of style changes around chained method invocations
  • Loading branch information
dbushong committed Mar 24, 2020
1 parent aa4f999 commit 6c004e6
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 12 deletions.
8 changes: 1 addition & 7 deletions lib/rules/opinions.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,7 @@
*/
module.exports = {
// See: https://github.com/prettier/eslint-plugin-prettier
'prettier/prettier': [
'error',
{
singleQuote: true,
trailingComma: 'es5',
},
],
'prettier/prettier': ['error', { singleQuote: true, arrowParens: 'avoid' }],

// See: https://eslint.org/docs/rules/lines-around-directive
'lines-around-directive': ['error', 'always'],
Expand Down
6 changes: 3 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"eslint-plugin-node": ">=10.0.0",
"eslint-plugin-prettier": ">=3.1.0",
"eslint": "^6",
"prettier": ">=1.18.2"
"prettier": ">=2.0.0"
},
"dependencies": {},
"devDependencies": {
Expand All @@ -52,7 +52,7 @@
"mocha": "^7.0.1",
"nlm": "^3.6.3",
"npm-run-all": "^4.1.5",
"prettier": "^1.19.1"
"prettier": "^2.0.2"
},
"author": {
"name": "Jan Krems",
Expand Down

0 comments on commit 6c004e6

Please sign in to comment.