Skip to content

Commit

Permalink
refactor: Upgrade to ESLint 5
Browse files Browse the repository at this point in the history
BREAKING CHANGE: This config now builds on top of ESLint 5. This
also affects other `peerDependencies` like certain plugins.
  • Loading branch information
Jan Krems committed Jul 18, 2018
1 parent 3067cfd commit 986105d
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 20 deletions.
2 changes: 1 addition & 1 deletion examples/eslint/node8/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ module.exports = Object.assign({
},
rules: {
'node/no-unsupported-features': [2, {
version: 8,
version: '8.3.0',
ignores: ['modules'],
}],
},
Expand Down
5 changes: 1 addition & 4 deletions lib/basics.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,8 @@ module.exports = {
node: true,
},
parserOptions: {
ecmaVersion: 2017,
ecmaVersion: 2018,
sourceType: 'script',
ecmaFeatures: {
experimentalObjectRestSpread: true,
},
},
plugins: ['import', 'mocha', 'node', 'prettier'],
};
2 changes: 1 addition & 1 deletion node8.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,6 @@ module.exports = Object.assign(basics, {
// Additional conventions

// Additional mistakes
'node/no-unsupported-features': [2, { version: 8 }],
'node/no-unsupported-features': [2, { version: '8.3.0' }],
}),
});
26 changes: 13 additions & 13 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,23 +25,23 @@
}
},
"peerDependencies": {
"eslint-plugin-import": "^2.2.0",
"eslint-plugin-mocha": "^4.12.1",
"eslint-plugin-node": "^5.1.1",
"eslint-plugin-prettier": "^2.2.0",
"eslint": "^4.5.0"
"eslint-plugin-import": "^2.8.0",
"eslint-plugin-mocha": "^5.1.0",
"eslint-plugin-node": "^7.0.1",
"eslint-plugin-prettier": "^2.6.2",
"eslint": "^5.1.0"
},
"dependencies": {},
"devDependencies": {
"assertive": "^2.1.0",
"eslint": "^4.7.1",
"assertive": "^3.0.0",
"eslint": "^5.1.0",
"eslint-plugin-import": "^2.8.0",
"eslint-plugin-mocha": "^4.12.1",
"eslint-plugin-node": "^5.1.1",
"eslint-plugin-prettier": "^2.2.0",
"globby": "^6.1.0",
"mocha": "^3.5.0",
"nlm": "^3.3.0",
"eslint-plugin-mocha": "^5.1.0",
"eslint-plugin-node": "^7.0.1",
"eslint-plugin-prettier": "^2.6.2",
"globby": "^8.0.1",
"mocha": "^5.2.0",
"nlm": "^3.3.1",
"prettier": "^1.6.1"
},
"author": {
Expand Down
2 changes: 1 addition & 1 deletion test/lint.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ async function validate(filename, content) {

describe(`Linting using ESLint`, () => {
const files = globby.sync(`examples/**/*.{mjs,js}`, {
ignore: 'examples/node_modules/**/*.*',
ignore: ['examples/node_modules/**/*.*'],
});

files.forEach(testFile => {
Expand Down

0 comments on commit 986105d

Please sign in to comment.