Skip to content

Commit

Permalink
feat: support all versions automatically
Browse files Browse the repository at this point in the history
now instead of `groupon/nodeN`, you just extend `groupon`

the node version will be selected based on your `package.json`
`engines.node` setting.

Note that for what we think of as node 8 features, you should specify
`>=8.3.0`

BREAKING CHANGE: /nodeN entrypoints are gone; you must specify a
`engines.node` section in your `package.json`; new defaults as specified
by adding `extends: plugin:node/recommended`; dropped support for node 6
and node 4 and es5
  • Loading branch information
dbushong committed Oct 26, 2019
1 parent 16297a4 commit a207b40
Show file tree
Hide file tree
Showing 65 changed files with 48 additions and 636 deletions.
19 changes: 1 addition & 18 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,23 +1,6 @@
{
"extends": "groupon/node8",
"extends": "./",
"overrides": [
{
"files": "*.mjs",
"parserOptions": {
"sourceType": "module"
},
"rules": {
"node/no-unsupported-features": [
"error",
{
"version": 8,
"ignores": [
"modules"
]
}
]
}
},
{
"files": "*.test.js",
"env": {
Expand Down
65 changes: 0 additions & 65 deletions es5.js

This file was deleted.

3 changes: 0 additions & 3 deletions examples/eslint/es5/.eslintrc.js

This file was deleted.

9 changes: 0 additions & 9 deletions examples/eslint/es5/consistent-return.js

This file was deleted.

1 change: 0 additions & 1 deletion examples/eslint/es5/consistent-return.js.json

This file was deleted.

11 changes: 0 additions & 11 deletions examples/eslint/es5/eqeqeq.js

This file was deleted.

1 change: 0 additions & 1 deletion examples/eslint/es5/eqeqeq.js.json

This file was deleted.

3 changes: 0 additions & 3 deletions examples/eslint/es5/no-arrow.js

This file was deleted.

3 changes: 0 additions & 3 deletions examples/eslint/es5/no-arrow.js.json

This file was deleted.

3 changes: 0 additions & 3 deletions examples/eslint/es5/no-class.js

This file was deleted.

7 changes: 0 additions & 7 deletions examples/eslint/es5/no-class.js.json

This file was deleted.

3 changes: 0 additions & 3 deletions examples/eslint/es5/no-prefer-arrow.js

This file was deleted.

4 changes: 0 additions & 4 deletions examples/eslint/es5/no-prefer-template.js

This file was deleted.

3 changes: 0 additions & 3 deletions examples/eslint/es5/no-prefer-template.js.json

This file was deleted.

5 changes: 0 additions & 5 deletions examples/eslint/es5/no-promise.js

This file was deleted.

3 changes: 0 additions & 3 deletions examples/eslint/es5/no-promise.js.json

This file was deleted.

8 changes: 0 additions & 8 deletions examples/eslint/es5/strict.js

This file was deleted.

7 changes: 0 additions & 7 deletions examples/eslint/es5/underscore-dangle.js

This file was deleted.

3 changes: 0 additions & 3 deletions examples/eslint/node10/.eslintrc.js

This file was deleted.

3 changes: 3 additions & 0 deletions examples/eslint/node10/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"engines": { "node": ">=10" }
}
3 changes: 3 additions & 0 deletions examples/eslint/node12/object-from-entries.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
'use strict';

module.exports = Object.fromEntries([['a', 1], ['b', 2]]);
3 changes: 3 additions & 0 deletions examples/eslint/node12/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"engines": { "node": ">=12" }
}
3 changes: 0 additions & 3 deletions examples/eslint/node4/.eslintrc.js

This file was deleted.

6 changes: 0 additions & 6 deletions examples/eslint/node4/arguments.js

This file was deleted.

23 changes: 0 additions & 23 deletions examples/eslint/node4/comma-dangle.js

This file was deleted.

6 changes: 0 additions & 6 deletions examples/eslint/node4/generator.js

This file was deleted.

5 changes: 0 additions & 5 deletions examples/eslint/node4/global-promise.js

This file was deleted.

11 changes: 0 additions & 11 deletions examples/eslint/node4/object-shorthand.js

This file was deleted.

11 changes: 0 additions & 11 deletions examples/eslint/node4/object-shorthand.out.js

This file was deleted.

21 changes: 0 additions & 21 deletions examples/eslint/node4/prefer-arrow-callback.js

This file was deleted.

7 changes: 0 additions & 7 deletions examples/eslint/node4/prefer-spread.js

This file was deleted.

15 changes: 0 additions & 15 deletions examples/eslint/node4/underscore-dangle.js

This file was deleted.

3 changes: 0 additions & 3 deletions examples/eslint/node6/.eslintrc.js

This file was deleted.

23 changes: 0 additions & 23 deletions examples/eslint/node6/comma-dangle.js

This file was deleted.

6 changes: 0 additions & 6 deletions examples/eslint/node6/default-args.js

This file was deleted.

7 changes: 0 additions & 7 deletions examples/eslint/node6/destruct.js

This file was deleted.

6 changes: 0 additions & 6 deletions examples/eslint/node6/generator.js

This file was deleted.

5 changes: 0 additions & 5 deletions examples/eslint/node6/invalid-import.js

This file was deleted.

3 changes: 0 additions & 3 deletions examples/eslint/node6/invalid-import.js.json

This file was deleted.

7 changes: 0 additions & 7 deletions examples/eslint/node6/long-string.js

This file was deleted.

8 changes: 0 additions & 8 deletions examples/eslint/node6/long-string.out.js

This file was deleted.

3 changes: 0 additions & 3 deletions examples/eslint/node6/missing-syntax.js

This file was deleted.

3 changes: 0 additions & 3 deletions examples/eslint/node6/missing-syntax.out.js

This file was deleted.

0 comments on commit a207b40

Please sign in to comment.