Skip to content

Commit

Permalink
fix: Add more --fix test cases
Browse files Browse the repository at this point in the history
  • Loading branch information
Jan Krems committed Aug 25, 2017
1 parent ef674e4 commit c42aeb7
Show file tree
Hide file tree
Showing 9 changed files with 43 additions and 11 deletions.
4 changes: 2 additions & 2 deletions es5.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict';

const opinions = require('./lib/rules/opinions');
const conventions = require('./lib/rules/opinions');
const conventions = require('./lib/rules/conventions');
const mistakes = require('./lib/rules/mistakes');

module.exports = Object.assign({
Expand All @@ -14,7 +14,7 @@ module.exports = Object.assign({
sourceType: 'script',
},
plugins: ['import', 'node', 'prettier'],
rules: Object.assign(opinions, conventions, mistakes, {
rules: Object.assign({}, opinions, conventions, mistakes, {
// Additional opinions

// Additional conventions
Expand Down
3 changes: 3 additions & 0 deletions examples/eslint/node6/missing-syntax.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
'use strict'

process.stdout.write('Wrap!\n')
3 changes: 3 additions & 0 deletions examples/eslint/node6/missing-syntax.out.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
'use strict';

process.stdout.write('Wrap!\n');
5 changes: 5 additions & 0 deletions examples/eslint/node6/undef-init.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
'use strict';

let x = undefined;
x = 42;
(() => {})(x); // "use"
5 changes: 5 additions & 0 deletions examples/eslint/node6/undef-init.out.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
'use strict';

let x;
x = 42;
(() => {})(x); // "use"
21 changes: 18 additions & 3 deletions lib/rules/conventions.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,23 @@
* might be a moving target.
*/
module.exports = {
/*
* See: http://eslint.org/docs/rules/no-underscore-dangle
*/
'no-underscore-dangle': ['warn', { allowAfterThis: true }],
'no-undef-init': 'off', // pending: Can't be auto-fixed
'import/no-dynamic-require': 'off', // pending: Can't be auto-fixed
strict: [2, 'global'],

/*
* See: http://eslint.org/docs/rules/no-undef-init
*/
'no-undef-init': 'error',

/*
* See: http://eslint.org/docs/rules/strict
*/
strict: ['warn', 'global'], // pending: Can't be auto-fixed

/*
* See: https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-dynamic-require.md
*/
'import/no-dynamic-require': 'warn', // pending: Can't be auto-fixed
};
4 changes: 2 additions & 2 deletions node4.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@
const basics = require('./lib/basics');

const opinions = require('./lib/rules/opinions');
const conventions = require('./lib/rules/opinions');
const conventions = require('./lib/rules/conventions');
const mistakes = require('./lib/rules/mistakes');

module.exports = Object.assign(basics, {
rules: Object.assign(opinions, conventions, mistakes, {
rules: Object.assign({}, opinions, conventions, mistakes, {
// Additional opinions

// Additional conventions
Expand Down
5 changes: 3 additions & 2 deletions node6.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@
const basics = require('./lib/basics');

const opinions = require('./lib/rules/opinions');
const conventions = require('./lib/rules/opinions');
const conventions = require('./lib/rules/conventions');
const mistakes = require('./lib/rules/mistakes');

module.exports = Object.assign(basics, {
rules: Object.assign(opinions, conventions, mistakes, {
rules: Object.assign({}, opinions, conventions, mistakes, {
// Additional opinions

// Additional conventions
Expand All @@ -16,3 +16,4 @@ module.exports = Object.assign(basics, {
'node/no-unsupported-features': [2, { version: 6 }],
})
});
console.log(module.exports.rules);
4 changes: 2 additions & 2 deletions node8.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@
const basics = require('./lib/basics');

const opinions = require('./lib/rules/opinions');
const conventions = require('./lib/rules/opinions');
const conventions = require('./lib/rules/conventions');
const mistakes = require('./lib/rules/mistakes');

module.exports = Object.assign(basics, {
rules: Object.assign(opinions, conventions, mistakes, {
rules: Object.assign({}, opinions, conventions, mistakes, {
// Additional opinions

// Additional conventions
Expand Down

0 comments on commit c42aeb7

Please sign in to comment.