Skip to content

Commit

Permalink
feat: resurrect no-console as error
Browse files Browse the repository at this point in the history
got lost in the de-airbnb-ification

in keeping with our "fatal or fixable", this is fatal, since it can
cause production performance issues if missed.
  • Loading branch information
dbushong committed Dec 2, 2017
1 parent 49ffcd9 commit f66914e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
2 changes: 2 additions & 0 deletions lib/rules/mistakes.js
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,8 @@ module.exports = {
'require-yield': 'error',
// See: https://eslint.org/docs/rules/no-compare-neg-zero
'no-constant-condition': 'error',
// See: https://eslint.org/docs/rules/no-console
'no-console': 'error',

// # Types & Misleading Syntax

Expand Down
1 change: 1 addition & 0 deletions test/lint.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ async function validate(filename, content) {
try {
assert.equal(first.errorCount, expected.errorCount);
} catch (e) {
// eslint-disable-next-line no-console
console.log(first.messages, expected.messages);
throw e;
}
Expand Down

0 comments on commit f66914e

Please sign in to comment.