fix: set prefer-template to off for es5 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkrems
approved these changes
Nov 20, 2017
|
Can we add a test for this? Potentially including a |
dbushong
reviewed
Nov 20, 2017
es5.js
Outdated
| @@ -57,5 +57,8 @@ module.exports = Object.assign({ | |||
|
|
|||
| // Additional mistakes | |||
| 'node/no-unsupported-features': [2, { version: 4 }], | |||
|
|
|||
| // Set Prefer Template to off -- currently 'on' via conventions | |||
| 'prefer-template': 'off' | |||
There was a problem hiding this comment.
I'd probably put this up in the // Additional conventions "paragraph"
There was a problem hiding this comment.
Good point. Even though it is a syntax error (mistake) in ES5, enabling the rule was a convention so the override is also a convention..?
jkrems
approved these changes
Nov 20, 2017
markowsiak
force-pushed
the
mo-prefer-template-off-in-es5
branch
2 times, most recently
from
9242b1a
to
0c19e2b
Compare
markowsiak
force-pushed
the
mo-prefer-template-off-in-es5
branch
from
0c19e2b
to
fb601e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.