Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resurrect no-console as error #23

Merged
merged 2 commits into from
Dec 2, 2017
Merged

resurrect no-console as error #23

merged 2 commits into from
Dec 2, 2017

Conversation

dbushong
Copy link
Member

@dbushong dbushong commented Dec 2, 2017

  • feat: resurrect no-console as error
  • chore: add nvmrc for node8 dev compliance

@dbushong
feat: resurrect no-console as error
f66914e 
got lost in the de-airbnb-ification

in keeping with our "fatal or fixable", this is fatal, since it can
cause production performance issues if missed.
@dbushong
chore: add nvmrc for node8 dev compliance
57a5ff9
jkrems
jkrems approved these changes Dec 2, 2017
View reviewed changes
Copy link
Contributor

@jkrems jkrems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:, valid use of error since rogue console.log statements can cause serious production issues.

@dbushong dbushong merged commit b83694c into master Dec 2, 2017
@dbushong dbushong deleted the dbushong/feature/master/no-console branch December 2, 2017 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkrems jkrems jkrems approved these changes

Assignees
No one assigned
Labels
semver-minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dbushong @jkrems @i-tier-bot