Upgrade to ESLint 5 #32
Merged
+17
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: This config now builds on top of ESLint 5. This also affects other `peerDependencies` like certain plugins.
dbushong
reviewed
Jul 18, 2018
| @@ -10,7 +10,7 @@ module.exports = Object.assign({ | |||
| }, | |||
| rules: { | |||
| 'node/no-unsupported-features': [2, { | |||
| version: 8, | |||
| version: '8.3.0', | |||
There was a problem hiding this comment.
It's more correct now - technically object spread was only added in 8.3 apparently. So with just "8" it complains that object spread isn't supported.
dbushong
approved these changes
Jul 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: This config now builds on top of ESLint 5. This
also affects other
peerDependencieslike certain plugins.This PR was started by: git wf pr