Complete refactor + Node 12.x (and beyond) support #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now instead of `groupon/nodeN`, you just extend `groupon` the node version will be selected based on your `package.json` `engines.node` setting. Note that for what we think of as node 8 features, you should specify `>=8.3.0` BREAKING CHANGE: /nodeN entrypoints are gone; you must specify a `engines.node` section in your `package.json`; new defaults as specified by adding `extends: plugin:node/recommended`; dropped support for node 6 and node 4 and es5
* the unpublished-require checks is broken for the way we use devDeps
* the deprecated-api check shouldn't kill use of e.g.
require('url')...for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ES5 and old Nodes removed. In exchange, we depend on new features in
eslint-plugin-nodeto auto-detect node version and handle module mode based on file extensions andpackage.jsonengines.nodesettings.This PR was started by: git wf pr