Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrades and typescript #54

Merged
merged 2 commits into from
Nov 5, 2021

Conversation

dbushong
Copy link
Member

@dbushong dbushong commented Nov 5, 2021

The eslint-plugin-prettier upgrade is a breaking change.

The new /typescript endpoint requires the new peerDependencies, but they're not required if you're not using that.

  • chore: upgrade to eslint-plugin-prettier 4.x
  • feat: add /typescript endpoint

This PR was started by: git wf pr

BREAKING CHANGE: requires bumping eslint-plugin-prettier to ^4
@dbushong
Copy link
Member Author

dbushong commented Nov 5, 2021

With this change, we'll be able to go from this:

https://github.com/groupon/gofer-openapi/blob/3eaefca4bd260d64d5d8bdaa1a0fdf80deab36f6/.eslintrc.json

to this:

{
  "root": true,
  "extends": [
    "groupon/typescript",
    "plugin:regexp/recommended"
  ],
  "overrides": [
    {
      "files": [
        "test/**"
      ],
      "env": {
        "mocha": true
      },
      "parserOptions": {
        "project": "test/tsconfig.json"
      }
    }
  ]
}

Copy link

@erothman-groupon erothman-groupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@aotarola aotarola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💚

@dbushong dbushong merged commit c625dfb into main Nov 5, 2021
@dbushong dbushong deleted the dbushong/feature/main/upgrades-and-typescript branch November 5, 2021 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants