add type checking & declarations #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: type decls for tags export....maybe
dbushong
commented
Oct 19, 2019
| @@ -52,5 +66,6 @@ const TAG_NAMES = | |||
| exports.h = h; | |||
|
|
|||
| TAG_NAMES.split('|').forEach(tag => { | |||
| // @ts-ignore | |||
| exports[tag] = hh.bind(null, tag); | |||
There was a problem hiding this comment.
the type declarations for this will be huge, since we'll have to explicitly split out all the tags; if we end up adding that later, we'll fix up the types in this file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also had to upgrade to preact 10.0.1 because they changed the VNode definition a bit (removed a
| null), so we might as well be based on the latest one in our declarations.Incidentally we now require node 8.
This PR was started by: git wf pr