Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: mocha bump #5

Merged
merged 1 commit into from
May 14, 2019
Merged

test: mocha bump #5

merged 1 commit into from
May 14, 2019

Conversation

aotarola
Copy link
Member

No description provided.

@aotarola aotarola force-pushed the aotarola/test/master/mocha-bump branch from f7a19b4 to 2392640 Compare May 14, 2019 15:30
@jkrems
Copy link
Collaborator

jkrems commented May 14, 2019

This sounds like the tests don't terminate. Later version of mocha removed the "exit once all tests finished" behavior (or moved it behind the --exit flag). A common fix is to make sure that we close all servers etc. in after blocks so the process exits naturally.

Another quick fix is to just add --exit to test/mocha.opts.

@aotarola
Copy link
Member Author

@jkrems yep, I already added it in package.json, do you think mocha.opts is more appropriate?

@jkrems
Copy link
Collaborator

jkrems commented May 14, 2019

Yes, we always want these kinds of changes in mocha.opts. Putting them into package.json removes the ability to simple run mocha test/file.test.js (or at least makes it behave differently). :)

@aotarola aotarola force-pushed the aotarola/test/master/mocha-bump branch from 615cab8 to 357bfa8 Compare May 14, 2019 15:38
@aotarola aotarola force-pushed the aotarola/test/master/mocha-bump branch from 357bfa8 to 5b293a6 Compare May 14, 2019 15:41
@aotarola aotarola merged commit 6239a47 into master May 14, 2019
@aotarola aotarola deleted the aotarola/test/master/mocha-bump branch May 14, 2019 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants