default setActive() to write cache files
#40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given legacy code which called `setActive()` with no arguments, we should also default to the old behavior of active mode writing out cache files. The broken case is when the shared store was instantiated not active, then `.setActive()` was called later with no arguments
jkrems
approved these changes
Sep 17, 2018
There was a problem hiding this comment.
LGTM. I think at this point we could also remove the typeof === 'boolean' check but I'm fine with keeping this minimal. It was meant to make .setActive() in a worker not update the _writeCacheFiles to true but I don't think it does what it's supposed to based on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given legacy code which called
setActive()with no arguments, weshould also default to the old behavior of active mode writing out cache
files.
The broken case is when the shared store was instantiated not active,
then
.setActive()was called later with no arguments