B submit - submit & vote buttons logic #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ripper234
requested changes
Mar 2, 2017
There was a problem hiding this comment.
Good progress, but not mature enough for merging yet.
- See comments inline in the code
- See issues b-submit branch: After submitting a proposal, the suggestion textbox never becomes enabled #83 and b-submit branch: Heart icon not styled correctly #84
| // POST /submit | ||
| router.post('/submit', function (req, res, next) { | ||
| var playerId = req.body.playerId | ||
| var suggestionDisabled = req.body.suggestionDisabled |
There was a problem hiding this comment.
Where is this parameter used?
| playerId: this.sharedState.playerId, | ||
| suggestionDisabled: this.suggestionDisabled | ||
| }, function (err, state) { | ||
| if (err) { console.log(err) } |
There was a problem hiding this comment.
This hides the error, should either be assert(!err) or window.alert(err)
(We should unify all error handling/display code into one place)
|
Also, tests are failing due to the changed functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.