Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate Android C++ compilation #56

Merged
merged 2 commits into from
Feb 18, 2018
Merged

Investigate Android C++ compilation #56

merged 2 commits into from
Feb 18, 2018

Conversation

grovesNL
Copy link
Owner

@grovesNL grovesNL commented Feb 11, 2018 •
edited

  • Add Android job to Travis to test compilation of an example binary
  • Refactor Travis configuration into separate scripts

@grovesNL grovesNL force-pushed the android branch 8 times, most recently from 83b8a41 to 44d5d45 Compare February 17, 2018 18:41
@codecov
Copy link

codecov bot commented Feb 17, 2018 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (master@81e88f9). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #56   +/-   ##
=========================================
  Coverage          ?   71.23%           
=========================================
  Files             ?        5           
  Lines             ?      584           
  Branches          ?        0           
=========================================
  Hits              ?      416           
  Misses            ?      168           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81e88f9...a6acd30. Read the comment docs.

@grovesNL
Copy link
Owner Author

The Android job seems to compile okay, although I couldn't seem to get the Android emulator working on Travis for the version of the Android SDK targeted here. So I don't know if it actually runs correctly yet on Android devices.

We should be able to simplify the Android setup further after rust-mobile/android-rs-glue#170 has been published.

bors r+

bors bot added a commit that referenced this pull request Feb 18, 2018
@bors
Merge #56
0fa02c6 
56: Investigate Android C++ compilation r=grovesNL a=grovesNL

- Add Android job to Travis to test compilation of an example binary
- Refactor Travis configuration into separate scripts
@bors
Copy link
Contributor

bors bot commented Feb 18, 2018

Build failed

@grovesNL
Copy link
Owner Author

bors r+

bors bot added a commit that referenced this pull request Feb 18, 2018
@bors
Merge #56
38c5d60 
56: Investigate Android C++ compilation r=grovesNL a=grovesNL

- Add Android job to Travis to test compilation of an example binary
- Refactor Travis configuration into separate scripts
@bors
Copy link
Contributor

bors bot commented Feb 18, 2018

Build succeeded

@bors bors bot merged commit a6acd30 into master Feb 18, 2018
@grovesNL grovesNL deleted the android branch February 18, 2018 09:01
@grovesNL grovesNL mentioned this pull request Mar 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@grovesNL