Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with transit/long encoding #1155

Closed
jeremydw opened this issue Apr 28, 2021 · 3 comments
Closed

Issue with transit/long encoding #1155

jeremydw opened this issue Apr 28, 2021 · 3 comments

Comments

@jeremydw
Copy link
Member

Issue encountered when building:

  File "/Users/jeremydw/.local/share/virtualenvs/project/lib/python3.9/site-packages/grow/common/utils.py", line 510, in slugify
    word = codecs.encode(word, 'translit/long')

We may want to find another way to slugify.

@Zoramite
Copy link
Member

Which version of Grow is that in? I thought I updated the translit version in one of the recent updates since there was a problem with it on later versions of python.

@jeremydw
Copy link
Member Author

The issue cropped up when using Grow as follows:

grow = "==1.0.0a10"

If it's been since fixed, great! Let me know and we'll update our projects. If not... let's probably figure out a different slugify approach. I can delete this offending line and see no ill effects with my project (although we'd want to verify any new technique passes tests).

@Zoramite
Copy link
Member

Yeah, I think it was fixed in 1.0.1. So you should update :) We are at 1.0.4 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants