fix(popover): update popover position when bottom is 0 (#1796)

* fix(popover): update popover position when bottom is 0 * fix(code): eslint Co-authored-by: Zhang Rui <zhangrui@growingio.com>
growingio · Jan 13, 2022 · 006451c · 006451c · vercel · Jan 13, 2022
1 parent 2da742b
commit 006451c
Showing 1 changed file with 15 additions and 15 deletions.
diff --git a/src/popover/usePop.ts b/src/popover/usePop.ts
@@ -36,17 +36,17 @@ const clear3D = (transform: string): string | number[] => {
   return transform;
 };
 
-const getMaxHeight = (element: HTMLElement, maxHeight = 0): number => {
-  if (!element) {
-    return maxHeight;
-  }
-  const elHeight = element.offsetHeight;
-  const newMax = elHeight > maxHeight ? elHeight : maxHeight;
-  if (element.parentElement) {
-    return getMaxHeight(element.parentElement, newMax);
-  }
-  return window.innerHeight > maxHeight ? window.innerHeight : maxHeight;
-};
+// const getMaxHeight = (element: HTMLElement, maxHeight = 0): number => {
+//   if (!element) {
+//     return maxHeight;
+//   }
+//   const elHeight = element.offsetHeight;
+//   const newMax = elHeight > maxHeight ? elHeight : maxHeight;
+//   if (element.parentElement) {
+//     return getMaxHeight(element.parentElement, newMax);
+//   }
+//   return window.innerHeight > maxHeight ? window.innerHeight : maxHeight;
+// };
 
 const getBottomOfElement = (element: HTMLElement) => element?.getBoundingClientRect()?.bottom;
 // const getElementHeight = (element: HTMLElement) => element.offsetHeight;
@@ -62,7 +62,7 @@ const usePop = ({ referenceElement, popperElement, placement, modifiers, strateg
     if (Array.isArray(three)) {
       const [x, y, z] = three;
       const divHeight = popperElement.offsetHeight;
-      const pageHeight = getMaxHeight(referenceElement);
+      // const pageHeight = getMaxHeight(referenceElement);
       const winHeight = window.innerHeight;
 
       if (styles?.popper?.bottom === 'auto') {
@@ -79,9 +79,9 @@ const usePop = ({ referenceElement, popperElement, placement, modifiers, strateg
         }
         styles.popper.transform = `translate3d(${x}px, ${yField}px, ${z || 0}px)`;
       } else if (styles?.popper?.bottom === '0') {
-        const maxYField = pageHeight - (window.pageYOffset + window.innerHeight);
-        const yField = y + divHeight > maxYField ? maxYField : y;
-        styles.popper.transform = `translate3d(${x}px, ${yField}px, ${z || 0}px)`;
+        // const maxYField = pageHeight - (window.pageYOffset + window.innerHeight);
+        // const yField = y + divHeight > maxYField ? maxYField : y;
+        styles.popper.transform = `translate3d(${x}px, ${y}px, ${z || 0}px)`;
       }
     }
   }