Skip to content

Commit

Permalink
fix(listPicker): 修复在非受控情况下开启allowClear,点击清除Icon的时候无效 (#2134)
Browse files Browse the repository at this point in the history
* fix:  修复在非受控情况下开启allowClear,点击清除Icon的时候无效 (#2133)

* fix unit-test

Co-authored-by: zhangshun <zhangshun@growingio.com>
Co-authored-by: YanHui <yanhui@growingio.com>
  • Loading branch information
3 people authored and jack0pan committed Jan 5, 2023
1 parent 9f5debe commit 7767a11
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 7 deletions.
1 change: 1 addition & 0 deletions src/list-picker/listPicker.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ export const ListPicker: React.FC<ListPickerProps> = (props) => {

const clearInput = () => {
setValue(undefined);
setPrevValue(undefined);
onClear?.();
onChange?.();
};
Expand Down
14 changes: 7 additions & 7 deletions src/static-date-picker/__tests__/index.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@ import StaticDatePicker from '../StaticDatePicker';
describe('Testing StaticDatePicker ', () => {
it('without params', () => {
render(<StaticDatePicker />);
expect(screen.getByText('26')).toBeTruthy();
expect(screen.getByText('24')).toBeTruthy();
});

it('disabledDate is function', () => {
render(<StaticDatePicker disabledDate={(current: Date) => current.getTime() > new Date().getTime()} />);
expect(screen.getByText('26')).toBeTruthy();
expect(screen.getByText('24')).toBeTruthy();
});

it('onPanelChange has onPanelChange', () => {
Expand All @@ -24,15 +24,15 @@ describe('Testing StaticDatePicker ', () => {

fireEvent.click(container.querySelector('button[class="gio-picker-header-super-prev-btn"]'));

expect(screen.getByText('26')).toBeTruthy();
expect(screen.getByText('24')).toBeTruthy();

fireEvent.click(container.querySelector('button[class="gio-picker-header-prev-btn"]'));

expect(screen.getByText('26')).toBeTruthy();
expect(screen.getByText('24')).toBeTruthy();

fireEvent.click(screen.getByText('26'));
fireEvent.click(screen.getByText('24'));

expect(screen.getByText('26')).toBeTruthy();
expect(screen.getByText('24')).toBeTruthy();
});

it('onPanelChange not onPanelChange', () => {
Expand All @@ -42,6 +42,6 @@ describe('Testing StaticDatePicker ', () => {

fireEvent.click(container.querySelector('button[class="gio-picker-header-super-prev-btn"]'));

expect(screen.getByText('26')).toBeTruthy();
expect(screen.getByText('24')).toBeTruthy();
});
});

0 comments on commit 7767a11

Please sign in to comment.