fix(table): fix table error (#1623)

Co-authored-by: maxin <maxin@growingio.com>
growingio · Dec 6, 2021 · 860e1a3 · 860e1a3 · vercel · Dec 6, 2021
1 parent 6cf8f7d
commit 860e1a3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/pagination/Pagination.tsx b/src/pagination/Pagination.tsx
@@ -77,8 +77,6 @@ const Pagination = WithRef<HTMLDivElement, PaginationProps>((props, ref) => {
       nav: textObject.ariaLabelNav,
     }[type]);
 
-  if (hideOnSinglePage && maxPages <= 1) return null;
-
   const paginationProviderValue = useMemo<PaginationContextType>(
     () => ({
       onPageSizeChange,
@@ -104,6 +102,8 @@ const Pagination = WithRef<HTMLDivElement, PaginationProps>((props, ref) => {
     ]
   );
 
+  if (hideOnSinglePage && maxPages <= 1) return null;
+
   return (
     <div ref={ref} data-testid="pagination" className={classNames([className, prefixCls])} {...otherProps}>
       <PaginationContext.Provider value={paginationProviderValue}>

diff --git a/src/table/hook/usePagination.tsx b/src/table/hook/usePagination.tsx
@@ -41,7 +41,9 @@ const usePagination = <RecordType,>(
     if (controlledCurrent * controlledPageSize > totalMemo) {
       onChange?.(Math.ceil(totalMemo / controlledPageSize) || 1, controlledPageSize);
     }
-  }, [controlledCurrent, controlledPageSize, onChange, totalMemo]);
+    // 不应该检测 onChange 依赖
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+  }, [controlledCurrent, controlledPageSize, totalMemo]);
 
   const paginationData = useMemo(() => {
     if (pagination === false || !controlledPageSize) {