Skip to content

Commit

Permalink
fix(Tooltip): set hideDelay to 0 (#1919)
Browse files Browse the repository at this point in the history
* fix(Tooltip): set hideDelay to 0

* fix(Popover): update eslint issue

* fix(dummy): trigger dummy commit

Co-authored-by: Zhang Rui <zhangrui@growingio.com>
  • Loading branch information
Ryan Zhang and Zhang Rui committed Mar 23, 2022
1 parent 8c44134 commit 924c679
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 5 deletions.
6 changes: 3 additions & 3 deletions src/popover/Popover.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ const Popover = (props: PopoverProps) => {
distoryOnHide = true,
onContentClick,
delay = 100,
hideDelay = 500,
...rest
} = props;

Expand Down Expand Up @@ -162,7 +163,6 @@ const Popover = (props: PopoverProps) => {
}, [onDocumentClick]);

// ============ end ============

const isClickToShow = useMemo(() => trigger.indexOf('click') !== -1, [trigger]);

const isHoverToShow = useMemo(() => trigger.indexOf('hover') !== -1, [trigger]);
Expand All @@ -189,9 +189,9 @@ const Popover = (props: PopoverProps) => {
mouseLeaveTimeout.current = setTimeout(() => {
mouseIsNotLeave.current = false;
isHoverToShow && updateVisible(false);
}, 500);
}, hideDelay);
},
[triggerChildEvent, isHoverToShow, updateVisible]
[triggerChildEvent, isHoverToShow, updateVisible, hideDelay]
);

const onClick = useCallback(
Expand Down
6 changes: 5 additions & 1 deletion src/popover/interface.ts
Original file line number Diff line number Diff line change
Expand Up @@ -120,9 +120,13 @@ export interface PopoverProps {
*/
offset?: number[];
/**
* delay mouseEnter mouseLeave 延迟
* delay mouseEnter 延迟
*/
delay?: number;
/**
* hide popup 延迟
*/
hideDelay?: number;
triggerClassName?: string;
distoryOnHide?: boolean;
}
1 change: 1 addition & 0 deletions src/tooltip/Tooltip.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ const Tooltip = (props: TooltipProps) => {
return (
<Popover
{...rest}
hideDelay={0}
allowArrow={allowArrow}
prefixCls={customizePrefixCls}
overlayClassName={classNames(prefixCls, overlayClassName)}
Expand Down
2 changes: 1 addition & 1 deletion src/tooltip/demos/Tooltip.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ export const Placement = Template.bind({});
Placement.args = {
arrowPointAtCenter: true,
overlay,
trigger: 'click',
trigger: 'hover',
};

const TriggerTemplate: Story<TooltipProps> = (args) => (
Expand Down

1 comment on commit 924c679

@vercel
Copy link

@vercel vercel bot commented on 924c679 Mar 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.