fix(table): fix onChange calls twice (#2042)

Co-authored-by: maxin <maxin@growingio.com>
growingio · May 25, 2022 · ce9995a · ce9995a · vercel · May 25, 2022
1 parent 4bfa539
commit ce9995a
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 12 deletions.
diff --git a/src/table/Title.tsx b/src/table/Title.tsx
@@ -25,19 +25,19 @@ const Title = <RecordType,>(props: TitleProps<RecordType>): React.ReactElement =
       const nextSortOrder = getNextSortDirection(sortDirections, sortOrder ?? null);
       const changedSorterState: SortState<RecordType> = sorterState
         ? {
-          ...sorterState,
-          sortOrder: nextSortOrder,
-        }
+            ...sorterState,
+            sortOrder: nextSortOrder,
+          }
         : {
-          sortOrder: nextSortOrder,
-          column,
-          isControlled: 'sortOrder' in column,
-          key: columnKey,
-          sortDirections,
-          sortPriorityOrder,
-        };
+            sortOrder: nextSortOrder,
+            column,
+            isControlled: 'sortOrder' in column,
+            key: columnKey,
+            sortDirections,
+            sortPriorityOrder,
+          };
 
-      onTriggerStateUpdate({ sorterState: updateSorterStates(changedSorterState) });
+      updateSorterStates(changedSorterState);
     };
 
     return (

diff --git a/src/table/demos/sorting/Sorting.stories.tsx b/src/table/demos/sorting/Sorting.stories.tsx
@@ -39,7 +39,15 @@ export const Sorting = () => {
       title: 'Address',
     },
   ];
-  return <Table<DataSourceType> pagination={false} dataSource={genDataSource()} columns={columns} rowKey="id" />;
+  return (
+    <Table<DataSourceType>
+      pagination={false}
+      onChange={action('handleTableChange')}
+      dataSource={genDataSource()}
+      columns={columns}
+      rowKey="id"
+    />
+  );
 };
 
 // ----------------------- Sorting -----------------------//