Upgrade @growthbook/growthbook #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bttf
force-pushed
the
adnan/upgrade-growthbook-js
branch
from
a718ee8
to
016ac9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1664
The JS SDK in devtools was out of date by several versions. Only recently have regressions started coming up (as noted in above linked issue). This PR 1) adds a CI job to catch when
@growthbook/growthbookis out-of-date and 2) upgrades said package to latestCaveats - The opening of a pull request isn't the most ideal time to check whether our SDK is out of date - it's best to check before publishing the extension. However having a CI job check for this the quickest way to have a forcing function somewhere in the lifecycle to ensure we stay up to date. No doubt if this CI check was there prior we would have caught this much earlier.
Changes:
src/**/*.ts@growthbook/growthbookto 0.28.0CI Job successfully failing:
