Skip to content

Commit

Permalink
Change method to underscore
Browse files Browse the repository at this point in the history
  • Loading branch information
jdorn committed Apr 11, 2024
1 parent 645dd0c commit 4476439
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions growthbook.py
Original file line number Diff line number Diff line change
Expand Up @@ -917,7 +917,7 @@ def __init__(
self._cache_ttl = cache_ttl
self.sticky_bucket_identifier_attributes = sticky_bucket_identifier_attributes
self.sticky_bucket_service = sticky_bucket_service
self.sticky_bucket_assignment_docs: dict = {}
self._sticky_bucket_assignment_docs: dict = {}
self._using_derived_sticky_bucket_attributes = not sticky_bucket_identifier_attributes
self._sticky_bucket_attributes: Optional[dict] = None

Expand Down Expand Up @@ -1457,9 +1457,9 @@ def _run(self, experiment: Experiment, featureId: Optional[str] = None) -> Resul
)
doc = data.get("doc", None)
if doc and data.get('changed', False):
if not self.sticky_bucket_assignment_docs:
self.sticky_bucket_assignment_docs = {}
self.sticky_bucket_assignment_docs[data.get('key')] = doc
if not self._sticky_bucket_assignment_docs:
self._sticky_bucket_assignment_docs = {}
self._sticky_bucket_assignment_docs[data.get('key')] = doc
self.sticky_bucket_service.save_assignments(doc)

# 14. Fire the tracking callback if set
Expand Down Expand Up @@ -1563,15 +1563,15 @@ def _get_sticky_bucket_assignments(self, attr: str = None, fallback: str = None)

_, hashValue = self._getHashValue(attr)
key = f"{attr}||{hashValue}"
if key in self.sticky_bucket_assignment_docs:
merged = self.sticky_bucket_assignment_docs[key].get("assignments", {})
if key in self._sticky_bucket_assignment_docs:
merged = self._sticky_bucket_assignment_docs[key].get("assignments", {})

if fallback:
_, hashValue = self._getHashValue(fallback)
key = f"{fallback}||{hashValue}"
if key in self.sticky_bucket_assignment_docs:
if key in self._sticky_bucket_assignment_docs:
# Merge the fallback assignments, but don't overwrite existing ones
for k, v in self.sticky_bucket_assignment_docs[key].get("assignments", {}).items():
for k, v in self._sticky_bucket_assignment_docs[key].get("assignments", {}).items():
if k not in merged:
merged[k] = v

Expand Down Expand Up @@ -1640,11 +1640,11 @@ def refresh_sticky_buckets(self, force: bool = False) -> None:
return

self._sticky_bucket_attributes = attributes
self.sticky_bucket_assignment_docs = self.sticky_bucket_service.get_all_assignments(attributes)
self._sticky_bucket_assignment_docs = self.sticky_bucket_service.get_all_assignments(attributes)

def _generate_sticky_bucket_assignment_doc(self, attribute_name: str, attribute_value: str, assignments: dict):
key = attribute_name + "||" + attribute_value
existing_assignments = self.sticky_bucket_assignment_docs.get(key, {}).get("assignments", {})
existing_assignments = self._sticky_bucket_assignment_docs.get(key, {}).get("assignments", {})

new_assignments = {**existing_assignments, **assignments}

Expand Down

0 comments on commit 4476439

Please sign in to comment.