New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix isOn() for float values #30

Merged

tinahollygb merged 1 commit into main from bugfix/29-isOn-floats

Jul 6, 2023

Contributor

tinahollygb commented Jul 6, 2023

fixes #29 check for instance of Double in FeatureResult#isOn()


          fixes #29 check for instance of Double in FeatureResult#isOn()

cafd323

tinahollygb commented

View reviewed changes

lib/src/test/java/growthbook/sdk/java/FeatureResultTest.java

Comment on lines +119 to +129

+                  @Test
+                  void featureResult_isOn_withNonZeroValue_returnsTrue_forDoubles() {
+                      FeatureResult<Double> subject = FeatureResult
+                          .<Double>builder()
+                          .value(1.0)
+                          .source(FeatureResultSource.FORCE)
+                          .build();
+                      assertTrue(subject.isOn());
+                      assertFalse(subject.isOff());
+                  }

Contributor Author

tinahollygb Jul 6, 2023

This is the test case that would fail.

tinahollygb merged commit aa04bfa into main

6 checks passed

tinahollygb deleted the bugfix/29-isOn-floats branch

July 6, 2023 23:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment