Remove unnecessary null checks and change return type

growthbook · May 10, 2024 · 15d048a · 15d048a
1 parent 9d1b3c1
commit 15d048a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/packages/front-end/components/Ideas/ImpactModal.tsx b/packages/front-end/components/Ideas/ImpactModal.tsx
@@ -10,7 +10,7 @@ import Field from "@/components/Forms/Field";
 import SelectField from "@/components/Forms/SelectField";
 
 const ImpactModal: FC<{
-  idea?: IdeaInterface;
+  idea: IdeaInterface;
   estimate?: ImpactEstimateInterface;
   close: () => void;
   mutate: () => void;
@@ -23,9 +23,9 @@ const ImpactModal: FC<{
     defaultValues: {
       metric: estimate?.metric || metrics[0]?.id || "",
       segment: estimate?.segment || "",
-      userAdjustment: idea?.estimateParams?.userAdjustment || 100,
-      numVariations: idea?.estimateParams?.numVariations || 2,
-      improvement: idea?.estimateParams?.improvement || 10,
+      userAdjustment: idea.estimateParams.userAdjustment || 100,
+      numVariations: idea.estimateParams.numVariations || 2,
+      improvement: idea.estimateParams.improvement || 10,
     },
   });
 
@@ -58,7 +58,7 @@ const ImpactModal: FC<{
               body: JSON.stringify({
                 metric: value.metric,
                 segment: value.segment || null,
-                ideaId: idea?.id || null,
+                ideaId: idea.id || null,
               }),
             }
           );
@@ -97,7 +97,7 @@ const ImpactModal: FC<{
           },
         };
 
-        await apiCall(`/idea/${idea?.id}`, {
+        await apiCall(`/idea/${idea.id}`, {
           method: "POST",
           body: JSON.stringify(data),
         });

diff --git a/packages/front-end/components/Settings/Team/SingleRoleSelector.tsx b/packages/front-end/components/Settings/Team/SingleRoleSelector.tsx
@@ -57,7 +57,7 @@ export default function SingleRoleSelector({
         sort={false}
         formatOptionLabel={(value) => {
           const r = roles.find((r) => r.id === value.label);
-          if (!r) return <></>;
+          if (!r) return value.label;
           return (
             <div className="d-flex align-items-center">
               <strong style={{ width: 110 }}>{r.id}</strong>