Remove deprecated SQL group by column number syntax

growthbook · Mar 7, 2022 · 330df9e · 330df9e
1 parent dbae7e1
commit 330df9e
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/packages/back-end/src/integrations/SqlIntegration.ts b/packages/back-end/src/integrations/SqlIntegration.ts
@@ -215,7 +215,9 @@ export default abstract class SqlIntegration
         params.from
       )}
         GROUP BY
-          1, 2, 3
+          experiment_id,
+          variation_id,
+          ${this.dateTrunc(this.castUserDateCol("timestamp"))}
       ),
       __userThresholds as (
         SELECT
@@ -1093,7 +1095,7 @@ export default abstract class SqlIntegration
           FROM
             (${replaceDateVars(join.query, from, to)}) i
           GROUP BY
-            1, 2
+            ${id1}, ${id2}
           `;
         }
       }
@@ -1116,7 +1118,7 @@ export default abstract class SqlIntegration
           ${timestampColumn} >= ${this.toTimestamp(from)}
           ${to ? `AND ${timestampColumn} <= ${this.toTimestamp(to)}` : ""}
         GROUP BY
-          1, 2
+          user_id, anonymous_id
         `;
       }
     }