Allow uppercase letters in feature keys (#2491)

* Allow uppercase letters in feature keys * Fix extra word in docs
growthbook · May 10, 2024 · a2a7d19 · a2a7d19 · github-actions · May 10, 2024
1 parent c1fc9bc
commit a2a7d19
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 234 deletions.
diff --git a/docs/docs/features-old.mdx b/docs/docs/features-old.mdx
diff --git a/docs/docs/features/basics.mdx b/docs/docs/features/basics.mdx
@@ -15,13 +15,13 @@ If you make a mistake, you can always delete the feature and create a new one.
 
 <img src="/images/features/feature-create-feature-1.png" alt="Create Feature" width="600" />
 
-Feature keys must be all lowercase and include only letters, numbers, hyphens, and underscores.
+Feature keys must only include letters, numbers, hyphens, and underscores.
 
 Some examples of good feature keys:
 
 - `onboarding-checklist` - ON/OFF flag for a feature
 - `checkout_button_color` - The color of the checkout button
-- `results-per-page` - Number of search results to show per page
+- `resultsPerPage` - Number of search results to show per page
 
 ## Default Values
 

diff --git a/packages/back-end/src/api/features/postFeature.ts b/packages/back-end/src/api/features/postFeature.ts
@@ -90,7 +90,7 @@ export const postFeature = createApiRequestHandler(postFeatureValidator)(
       dateCreated: new Date(),
       dateUpdated: new Date(),
       organization: req.organization.id,
-      id: req.body.id.toLowerCase(),
+      id: req.body.id,
       archived: !!req.body.archived,
       version: 1,
       environmentSettings: {},

diff --git a/packages/back-end/src/controllers/features.ts b/packages/back-end/src/controllers/features.ts
@@ -441,7 +441,7 @@ export async function postFeatures(
     dateCreated: new Date(),
     dateUpdated: new Date(),
     organization: org.id,
-    id: id.toLowerCase(),
+    id,
     archived: false,
     version: 1,
     hasDrafts: false,