More Mongo mappings (#1359)

* map j->journal * minSize->minPoolSize * rm obsolete comment * fix test
growthbook · Jun 9, 2023 · ac0edeb · ac0edeb
1 parent 8eabf79
commit ac0edeb
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/packages/back-end/src/util/mongo.util.ts b/packages/back-end/src/util/mongo.util.ts
@@ -22,7 +22,6 @@
  *  - acceptableLatencyMS: is no longer documented. Possibly related: maxStalenessSeconds
  *  - connectWithNoPrimary: is no longer documented
  *  - w: still exists but is marked as deprecated -> writeConcern (incompatible types)
- *  - j: is no longer documented (journal write concern). -> writeConcern (incompatible types)
  *  - domainsEnabled: is no longer documented
  *  - bufferMaxEntries: is no longer documented
  *  - promiseLibrary: still exists but is marked as deprecated.
@@ -41,19 +40,24 @@ export const getConnectionStringWithDeprecatedKeysMigratedForV3to4 = (
     "secondaryAcceptableLatencyMS",
     "acceptableLatencyMS",
     "connectWithNoPrimary",
-    "j",
     "domainsEnabled",
     "bufferMaxEntries",
   ];
   const v3to4Mappings: Record<string, string> = {
+    minSize: "minPoolSize",
     poolSize: "maxPoolSize",
     tlsinsecure: "tlsInsecure",
 
     /**
-     * @deprecated
+     * @deprecated use WriteConcern
      */
     wtimeout: "wtimeoutMS",
 
+    /**
+     * @deprecated use WriteConcern
+     */
+    j: "journal",
+
     appname: "appName",
   };
 

diff --git a/packages/back-end/test/util/mongo.util.test.ts b/packages/back-end/test/util/mongo.util.test.ts
@@ -88,7 +88,7 @@ describe("mongo utils", () => {
         "mongodb://root:password@localhost:27017/growthbook?authSource=admin&poolSize=50&wtimeout=123456&appname=foobar&tlsinsecure=true&autoReconnect=true&reconnectRetries=3&reconnectInterval=300&ha=true&haInterval=300&secondaryAcceptableLatencyMS=1000&acceptableLatencyMS=1000&j=true&connectWithNoPrimary=true&domainsEnabled=false&bufferMaxEntries=10&foo=1&bar=2&baz=3";
       // includes original deprecated keys
       const expected =
-        "mongodb://root:password@localhost:27017/growthbook?authSource=admin&autoReconnect=true&reconnectRetries=3&reconnectInterval=300&ha=true&haInterval=300&secondaryAcceptableLatencyMS=1000&acceptableLatencyMS=1000&j=true&connectWithNoPrimary=true&domainsEnabled=false&bufferMaxEntries=10&foo=1&bar=2&baz=3&maxPoolSize=50&tlsInsecure=true&wtimeoutMS=123456&appName=foobar";
+        "mongodb://root:password@localhost:27017/growthbook?authSource=admin&autoReconnect=true&reconnectRetries=3&reconnectInterval=300&ha=true&haInterval=300&secondaryAcceptableLatencyMS=1000&acceptableLatencyMS=1000&connectWithNoPrimary=true&domainsEnabled=false&bufferMaxEntries=10&foo=1&bar=2&baz=3&maxPoolSize=50&tlsInsecure=true&wtimeoutMS=123456&journal=true&appName=foobar";
 
       const {
         url,
@@ -103,6 +103,7 @@ describe("mongo utils", () => {
         "poolSize",
         "tlsinsecure",
         "wtimeout",
+        "j",
         "appname",
       ]);
       expect(unsupported).toEqual([
@@ -113,7 +114,6 @@ describe("mongo utils", () => {
         "secondaryAcceptableLatencyMS",
         "acceptableLatencyMS",
         "connectWithNoPrimary",
-        "j",
         "domainsEnabled",
         "bufferMaxEntries",
       ]);