REST API - Allow updating in-progress conversion, attribution model, …

…and stats engine for experiment settings
growthbook · Apr 26, 2024 · ac7c58e · ac7c58e
1 parent 75ca41b
commit ac7c58e
Show file tree

Hide file tree

Showing 5 changed files with 45 additions and 1 deletion.
diff --git a/packages/back-end/generated/spec.yaml b/packages/back-end/generated/spec.yaml
diff --git a/packages/back-end/src/api/openapi/payload-schemas/UpdateExperimentPayload.yaml b/packages/back-end/src/api/openapi/payload-schemas/UpdateExperimentPayload.yaml
@@ -58,6 +58,21 @@ properties:
     type: string
   excludeFromPayload:
     type: boolean
+  inProgressConversions:
+    type: string
+    enum:
+      - loose
+      - strict
+  attributionModel:
+    type: string
+    enum:
+      - firstExposure
+      - experimentDuration
+  statsEngine:
+    type: string
+    enum:
+      - bayesian
+      - frequentist
   variations:
     type: array
     minItems: 2

diff --git a/packages/back-end/src/services/experiments.ts b/packages/back-end/src/services/experiments.ts
@@ -1853,6 +1853,9 @@ export function updateExperimentApiPayloadToInterface(
     variations,
     releasedVariationId,
     excludeFromPayload,
+    inProgressConversions,
+    attributionModel,
+    statsEngine,
   } = payload;
   return {
     ...(trackingKey ? { trackingKey } : {}),
@@ -1871,6 +1874,11 @@ export function updateExperimentApiPayloadToInterface(
     ...(status ? { status } : {}),
     ...(releasedVariationId !== undefined ? { releasedVariationId } : {}),
     ...(excludeFromPayload !== undefined ? { excludeFromPayload } : {}),
+    ...(inProgressConversions !== undefined
+      ? { skipPartialData: inProgressConversions === "strict" }
+      : {}),
+    ...(attributionModel !== undefined ? { attributionModel } : {}),
+    ...(statsEngine !== undefined ? { statsEngine } : {}),
     ...(variations
       ? {
           variations: variations?.map((v) => ({

diff --git a/packages/back-end/src/validators/openapi.ts b/packages/back-end/src/validators/openapi.ts
diff --git a/packages/back-end/types/openapi.d.ts b/packages/back-end/types/openapi.d.ts