Allow multi hover on metric graphs #1075
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your preview environment pr-1075-bttf has been deployed. Preview environment endpoints are available at: |
lukesonnet
approved these changes
Mar 14, 2023
lukesonnet
reviewed
Mar 14, 2023
| ...data.map((d) => | ||
| type === "binomial" | ||
| ? d.c | ||
| : Math.min(d.v * 2, d.v + (d.s ?? 0) * 2) |
There was a problem hiding this comment.
This logic is repeated a couple of places, IDK, if you wanted to put them in one place which might make a later refactor using sums and sums of squares a bit easier. But not a big deal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up from a recent change that plots 2 <DateGraph>s on a metric page (average, sum). This change allows for cross-graph hover states, so that you can see the tooltip track on both views at the same time.
Dependencies
Testing
Screenshots
multi-hover-metric-graphs.mov