Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Flag Experiment Links #1139

Merged
merged 57 commits into from Aug 9, 2023
Merged

Feature Flag Experiment Links #1139

merged 57 commits into from Aug 9, 2023

Commits on Apr 4, 2023

  1. Feature Flag Experiment References 

    Currently, feature flag experiment rules define all of the targeting and assignment parameters inline. Then, an entirely separate Experiment object must be created for analysis.

Both the Experiment and the Feature Rule have copies of variation weights, coverage, etc. and it's easy for them to get out-of-sync.

This PR makes the Experiment the source-of-truth. Adding an experiment rule to a feature will just reference the Experiment id instead of defining settings inline.
    @jdorn
    jdorn committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    9039a18 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2023

  1. Merge remote-tracking branch 'origin/main' into feature-experiment-ref

    @jdorn
    jdorn committed May 11, 2023
    Configuration menu
    Copy the full SHA
    39ecb00 View commit details
    Browse the repository at this point in the history

  2. Fix lint errors

    @jdorn
    jdorn committed May 11, 2023
    Configuration menu
    Copy the full SHA
    c485ca7 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2023

  1. Merge branch 'main' into feature-experiment-ref

    @jdorn
    jdorn committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    c24d134 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. Merge remote-tracking branch 'origin/main' into feature-experiment-ref

    @jdorn
    jdorn committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    0402bd5 View commit details
    Browse the repository at this point in the history

  2. Add experiment ref rules to SDK payloads

    @jdorn
    jdorn committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    a8366e9 View commit details
    Browse the repository at this point in the history

  3. Add hashVersion setting for experiments, make `includeExperimentNames… 

    …` setting for SDK connections apply to both visual editor changes and feature flags
    @jdorn
    jdorn committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    5594b1a View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/main' into feature-experiment-ref

    @jdorn
    jdorn committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    34ebd53 View commit details
    Browse the repository at this point in the history

  5. Fix type errors, hook up experiment ref rules to JSON Schema validation

    @jdorn
    jdorn committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    e691363 View commit details
    Browse the repository at this point in the history

  6. Remove ExperimentRefSummary component, fix experiment links for legac… 

    …y rules
    @jdorn
    jdorn committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    cc6f06c View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. Add variation name to legacy features in payload

    @jdorn
    jdorn committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    bbec515 View commit details
    Browse the repository at this point in the history

  2. Add simple rule summary component, update openapi docs

    @jdorn
    jdorn committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    566c6a0 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Merge remote-tracking branch 'origin/main' into feature-experiment-ref

    @jdorn
    jdorn committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    314028b View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. Integrate feature flags with new excludeFromPayload flag

    @jdorn
    jdorn committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    be5f874 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Merge remote-tracking branch 'origin/main' into feature-experiment-ref

    @jdorn
    jdorn committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    55ba484 View commit details
    Browse the repository at this point in the history

  2. Use actual SDK types to avoid getting out-of-sync

    @jdorn
    jdorn committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    1e26090 View commit details
    Browse the repository at this point in the history

  3. Util functions to check if an experiment has linked changes and shoul… 

    …d be included in a payload
    @jdorn
    jdorn committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    bb50e16 View commit details
    Browse the repository at this point in the history

  4. Update test cases

    @jdorn
    jdorn committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    995673e View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. Merge remote-tracking branch 'origin/main' into feature-experiment-ref

    @jdorn
    jdorn committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    39cb803 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2023

  1. Hook up front-end

    @jdorn
    jdorn committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    272151b View commit details
    Browse the repository at this point in the history

  2. Lint fixes

    @jdorn
    jdorn committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    605edda View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. Add feature flag from experiment page, bug fixes from testing

    @jdorn
    jdorn committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    af58138 View commit details
    Browse the repository at this point in the history

  2. Auto-open visual editor after creating a new visual changeset.

    @jdorn
    jdorn committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    c13704c View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Streamline experiment creation flow when designing a new experiment

    @jdorn
    jdorn committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    a37cea6 View commit details
    Browse the repository at this point in the history

  2. Handle case when a datasource is not specified for an experiment

    @jdorn
    jdorn committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    d723d87 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into feature-experiment-ref

    @jdorn
    jdorn committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    a0b50f3 View commit details
    Browse the repository at this point in the history

  4. Copy tweaks

    @jdorn
    jdorn committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    ad554e7 View commit details
    Browse the repository at this point in the history

  5. Fix typo

    @jdorn
    jdorn committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    05c8e8e View commit details
    Browse the repository at this point in the history

  6. When adding experiment rule to feature, default to creating a new exp… 

    …eriment
    @jdorn
    jdorn committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    3fbf3c3 View commit details
    Browse the repository at this point in the history

  7. Better messaging when a user doesn't have any experiments yet and the… 

    …y try to add an existing experiment to a feature
    @jdorn
    jdorn committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    c1ccecc View commit details
    Browse the repository at this point in the history

  8. Always show new experiment rule option

    @jdorn
    jdorn committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    620f1f5 View commit details
    Browse the repository at this point in the history

  9. Add pre-launch checklist, fix typo

    @jdorn
    jdorn committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    3e4b3b6 View commit details
    Browse the repository at this point in the history

  10. Fix bug with coverage variable

    @jdorn
    jdorn committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    1d135c8 View commit details
    Browse the repository at this point in the history

  11. Better disabled state for skipped experiment rules

    @jdorn
    jdorn committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    6726ad7 View commit details
    Browse the repository at this point in the history

  12. Make skipped rules more obvious

    @jdorn
    jdorn committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    bfe8838 View commit details
    Browse the repository at this point in the history

  13. Fix typo

    @jdorn
    jdorn committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    f5a484a View commit details
    Browse the repository at this point in the history

  14. Block duplicates when linking an existing feature flag to an experiment.

    @jdorn
    jdorn committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    fdfc0d2 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. Dedicated API endpoint to add an experiment to an existing feature

    @jdorn
    jdorn committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    492e10f View commit details
    Browse the repository at this point in the history

  2. Tooltip explaining hash V2 support

    @jdorn
    jdorn committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    e22868a View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. Fixes from code review

    @jdorn
    jdorn committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    ea2d126 View commit details
    Browse the repository at this point in the history

  2. UI fixes from PR review

    @jdorn
    jdorn committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    2224a62 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. UI changes to experiment page

    @jdorn
    jdorn committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    745a15e View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. Only show legacy experiment rule option if forced

    @jdorn
    jdorn committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    f8cb942 View commit details
    Browse the repository at this point in the history

  2. Fixes from testing

    @jdorn
    jdorn committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    4079675 View commit details
    Browse the repository at this point in the history

  3. Remove hash version selector from initial experiment modal. Add confi… 

    …rmation step to "Stop Temporary Rollout" button.
    @jdorn
    jdorn committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    e543a65 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. Merge remote-tracking branch 'origin/main' into feature-experiment-ref

    @jdorn
    jdorn committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    0fc9f7a View commit details
    Browse the repository at this point in the history

  2. Improve targeting meta info UX

    @jdorn
    jdorn committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    b45a341 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into feature-experiment-ref

    @jdorn
    jdorn committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    b4b4658 View commit details
    Browse the repository at this point in the history

  4. Design tweaks from review

    @jdorn
    jdorn committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    5277243 View commit details
    Browse the repository at this point in the history

  5. Use consistent Experiment Key naming

    @jdorn
    jdorn committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    be0b2f4 View commit details
    Browse the repository at this point in the history

  6. More design tweaks

    @jdorn
    jdorn committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    f3ac8f0 View commit details
    Browse the repository at this point in the history

  7. Allow starting with confirmation modal even when pre-launch checklist… 

    … is not finished
    @jdorn
    jdorn committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    0cd87c7 View commit details
    Browse the repository at this point in the history

  8. Bug fix feature warning and start button styles

    @jdorn
    jdorn committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    dab3eda View commit details
    Browse the repository at this point in the history

  9. Add warnings and confirmations before making changes that may break l… 

    …inked features
    @jdorn
    jdorn committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    23d0cd6 View commit details
    Browse the repository at this point in the history

  10. Add banner introducing new expeirment rules to existing users

    @jdorn
    jdorn committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    0e6b8b1 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. Merge remote-tracking branch 'origin/main' into feature-experiment-ref

    @jdorn
    jdorn committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    2f9bdf3 View commit details
    Browse the repository at this point in the history

  2. Reference new Go release for hash version, copy tweaks

    @jdorn
    jdorn committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    5dcf3c1 View commit details
    Browse the repository at this point in the history