New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version string comparison support to the conditions UI #1321
Add version string comparison support to the conditions UI #1321
Conversation
GB-262 [FE] Version string comparison UI
Add support for version string comparison in the existing UI Acceptance Criteria
|
Your preview environment pr-1321-bttf has been deployed. Preview environment endpoints are available at: |
Instead of adding these new operators to every string attribute, we only want to do it for attributes that are version strings. So that requires modifying the export type AttributeFormat = "none" | "version";
// In back-end/types/organization
export type SDKAttribute = {
...
format?: AttributeFormat;
};
// In front-end/services/features
export interface AttributeData {
...
format?: AttributeFormat;
} In the future, I can see us adding more formats like No need to add support for email or datetime formats now, but adding a |
@jdorn I updated the PR based on this feedback. See updated screenshots in the PR description. |
…n-string-comparison-ui
I realized it wouldn't be that hard to redesign the attribute page so you only create/edit a single attribute at a time. I think this greatly improves the UX and gives us more space to explain the different settings. Attribute list with More menu expanded: Create/Edit form: If you select "version" format: If you change the name of an existing attribute: If you try to add an attribute with a duplicate name: |
I created an issue for us to address a redesign of that page separately: #1330 |
Features and Changes
Adds some UI to support doing version string comparison targeting conditions.
Dependencies
Testing
version
greeting
of type stringYou can see an example of this implemented here.
Screenshots
UI for "greater than" and other comparison looks the same but under the hood uses the version string comparison operators.