Resolve missing types in TypeScript 5 #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leachtucker
force-pushed
the
tucker/ts5-typings
branch
from
e0f7b09
to
8166d04
Compare
|
Hi @leachtucker Could you specify which bundler you are using? |
|
Hey @bttf, we are using Vite. Although, this issue is not specific to Vite -- it occurs for any TS projects utilizing the new |
|
Hi @leachtucker Thanks for your patience. I was able to repro and the changes look good on my end. Will merge by EOD |
Hey @bttf. That sounds good! Thank you 🙂 |
bttf
approved these changes
Jun 9, 2023
|
Hello @bttf 👋 Would it be possible to release a new version of the packages to include this fix please ? Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features and Changes
moduleResolutionset tobundlerScreenshots
The resolved TS Error:
